react-rangeslider icon indicating copy to clipboard operation
react-rangeslider copied to clipboard

Ensure other key presses work as usual when the slider handle has focus

Open chrishutchinson opened this issue 8 years ago • 7 comments
trafficstars

Unfortunately my last PR was calling e.preventDefault() on all key presses after the slider handle had gained focus. This was preventing a user from tabbing to the next focusable element, or to any previous element. This restores that functionality, while keeping the arrow key controls.

chrishutchinson avatar Sep 20 '17 09:09 chrishutchinson

Resolves #90

paustint avatar Oct 18 '17 01:10 paustint

Could we get this merged @whoisandy ?

karl-run avatar Oct 26 '17 14:10 karl-run

Please merge this to fix the accessibility issue. Thanks

igilfillan avatar Nov 16 '17 16:11 igilfillan

@igilfillan: I had to abandon this library, I can recommend this: https://www.npmjs.com/package/react-slider

It's what we went with, it works very well and it's much better to style it from the bottom up instead of overwriting existing style.

karl-run avatar Nov 16 '17 18:11 karl-run

Any chance to merge this soon?

guilleccc avatar Sep 28 '18 10:09 guilleccc

@whoisandy Can you please review and merge this PR. Currently the keyboard accessibility is broken. Its impacting the entire page as the focus out of the slider is not working.

kancha12 avatar Oct 30 '18 18:10 kancha12

Yep, this is a deal breaker.

thomasnordlund avatar Jul 27 '21 15:07 thomasnordlund