react-blocks icon indicating copy to clipboard operation
react-blocks copied to clipboard

Published 20 hours ago • verified publisher icon whoisandy

Should media functionality be included as a part of react-blocks?

Open whoisandy opened this issue 9 years ago • 4 comments

The current version of react-blocks includes handling media queries. The question is, whether it should be at the core of the library? Also there are a couple of notable libraries out there that handle media queries specifically. Again CSS media queries could be another use case. If the feature helps you, please lemme know.

whoisandy avatar Nov 20 '15 07:11 whoisandy

I vote for remove media query stuff from this lib. :+1:

nishp1 avatar Dec 01 '15 22:12 nishp1

@nishp1 Any specific reason? Why not to include media queries as a part of the lib?

whoisandy avatar Dec 01 '15 23:12 whoisandy

For the same reasons mentioned in https://github.com/whoisandie/react-blocks/pull/6. Mainly just to simplify this library. I have used react-responsive in the past and I think that combined with this will work great together.

nishp1 avatar Dec 02 '15 04:12 nishp1

But don't you think for every block a separate <MediaQuery /> block has to be created which increases the boilerplate code? I mean, imho react-responsive also uses javascript to handle media queries under the hood.

whoisandy avatar Dec 02 '15 04:12 whoisandy