vscode-emacs-mcx icon indicating copy to clipboard operation
vscode-emacs-mcx copied to clipboard

Incorrect behavior when setting mark and searching

Open furious-luke opened this issue 2 years ago • 5 comments

Hi there, thanks for all the hard work on this extension, it's much appreciated!

I'm encountering an issue when trying to select regions of text over long ranges. Normally, I would set the mark at the beginning of the region I'm interested in selecting with CTRL+SPC, and then I would search to the position I'm interested in ending the region. So, I would do something like CTRL+S then type a short phrase to indicate the ending position. Then, I could perform an operation, like CTRL+W.

However, I'm noticing that in the above steps, when I hit CTRL+S my selection terminates. I believe the correct Emacs behavior is to maintain the selection over the search.

furious-luke avatar May 18 '22 02:05 furious-luke

Hi, @furious-luke . Do you find that CTRL+S works at all? I'm finding that it doesn't do anything, esp. when I unbind it for the native "Find" command and just have it bound to emacs-mcx.isearchForward.

dbikel avatar May 26 '22 14:05 dbikel

Thank you for the detailed description. That's right, the current C-s behavior with mark-mode is not emulating the original one. I will work on it.

whitphx avatar May 27 '22 16:05 whitphx

Hey @dbikel! Yep, CTRL+S works for me straight out of the box.

@whitphx Awesome, thanks so much!

furious-luke avatar May 30 '22 00:05 furious-luke

Okay, that's great, but is it true incremental search, or just a different keystroke to invoke the native Find command widget?

On Sun, May 29, 2022, 7:56 PM Luke Hodkinson @.***> wrote:

Hey @dbikel https://github.com/dbikel! Yep, CTRL+S works for me straight out of the box.

@whitphx https://github.com/whitphx Awesome, thanks so much!

— Reply to this email directly, view it on GitHub https://github.com/whitphx/vscode-emacs-mcx/issues/1328#issuecomment-1140567506, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUYZDPQVJ2GJJ4WISBXQTVMQGZ5ANCNFSM5WGZ7RQA . You are receiving this because you were mentioned.Message ID: @.***>

dbikel avatar May 30 '22 01:05 dbikel

@dbikel It's incremental search. It behaves very similarly to Emacs, except for the issue stated in my first post.

furious-luke avatar May 30 '22 02:05 furious-luke

This is also a very desirable feature for me. Thanks again for the great product, I don't know what I'd do without it!

rover-random avatar Oct 11 '23 15:10 rover-random

Fixed with 0.51.2 👍

whitphx avatar Nov 06 '23 04:11 whitphx

Works like a charm.

rover-random avatar Nov 06 '23 16:11 rover-random