canvabadges
canvabadges copied to clipboard
Adding I18n to canvabadges
Hello Whitmer,
Here is the pull request adding i18n mechanisms.
Some notes about it:
- I did not translate all the pages yet, we first focused on students' pages.
- Let me know if it is too messy so that I can clean the pull request
- I tested the application (using specs) and everything seemed fine, but I did not add any specs - I modified some specs because they were failing (because of old syntax)
I don't want this pull request to be to difficult for you to merge in your project, so, let me know if you need me to do anything to help you.
Regis.
Hi Regis, thanks for doing this. I opted to include only the i18n code and a couple of the translations for now. The full .yml files are merged in, but I'd feel more comfortable applying the translations in a separate step. I'll try to get to this soon-ish, but if you have some time it'd help if you'd do each .erb file as a separate commit so I can more easily see what's going on.
Thanks for spear-heading this!