json-refs icon indicating copy to clipboard operation
json-refs copied to clipboard

A few issues noticed as a result of a gulp attempt

Open brettz9 opened this issue 1 year ago • 4 comments

  • chore: lints
  • fix: adds overrides to avoid error on higher Node versions

Running the gulp script was giving the error:

ReferenceError: primordials is not defined

...which as per https://stackoverflow.com/a/58394828/271577 can be fixed by adding an overrides.

There were also a few linting errors, also fixed.

The browser tests still don't run, however.

I do have some energy at the moment, so am looking to make another, updated PR for ESM support, but have a couple questions on that:

  1. Do you still want to use gulp? If so, it seems updating to the latest packages can be made to work except that Istanbul doesn't currently work with ESM, so we'd need to move to c8 (there is a gulp-mocha-c8 plugin I could try).
  2. I'm not sure how well JSDoc will work with the ESM changes
  3. Are you ok dropping the very low minimum Node version you have now in engines in package.json to the LTS versions of Node? That should let us also have the binary in ESM without transpilation.

brettz9 avatar Nov 13 '22 22:11 brettz9