json-refs icon indicating copy to clipboard operation
json-refs copied to clipboard

Add unit test to that showcases Issue #154

Open saguinav opened this issue 5 years ago • 1 comments

This PR adds a unit test that showcases Issue #154

While I was writing this unit test I realized that the description I initially provided for this issue was not accurate. The real issue is that when only filter: ['relative'] option is provided the remote references contained by any relative reference are actually being fully resolved. On the other hand, I could successfully verify that remote references that are directly referenced are not being resolved (as expected).

To demonstrate this issue, I have added a remote reference inside the test file test-nested.yaml and created a new unit test that expects this remote reference NOT to be resolved.

I hope this PR is useful to understand this issue. As I said in the issue I'm opened to contribute with a fix.

Looking forward to your response @whitlockjc

Cheers!

saguinav avatar Mar 11 '19 23:03 saguinav

I'll take a peek.

whitlockjc avatar Mar 12 '19 02:03 whitlockjc