json-refs icon indicating copy to clipboard operation
json-refs copied to clipboard

Dependency on uri-js threatens node 0.8 - node 4.x compatibility

Open ethanherbertson opened this issue 7 years ago • 0 comments
trafficstars

The uri-js module makes no claims about what engines it supports, but sadly all recent versions of it (and indeed all versions still tagged/available on GitHub) rely on punycode 2.x, which only claims compatibility with node >= 6.0. (I've just filed https://github.com/garycourt/uri-js/issues/27 on uri-js to suggest he downgrade his dependency or at least add a "node >= 6.0" to his package.json.)

This module claims it supports node >= 0.8, but that nested dependency means it cannot (safely) claim to.

To fix this you'd either have to wait for uri-js to get "fixed", or you'd have to fork it or switch to a different URI library. Not sure which of those you'd prefer. In the meantime it's worth considering updating your supported engines to node >= 6.0.

ethanherbertson avatar Apr 13 '18 15:04 ethanherbertson