quest-sidenoder icon indicating copy to clipboard operation
quest-sidenoder copied to clipboard

Update frontend to Vue and rewrite backend

Open ov3rk1ll opened this issue 4 years ago • 4 comments

This MR contains the full rewrite/change based on 2db4aab from https://github.com/ov3rk1ll/vue-sidenoder.

Nearly all files are removed or at least modified so merging this would replace the entire code base.
As discussed in #30, I'll try to split this into multiple MRs but this is the entire code to make sure nothing is missed.

ov3rk1ll avatar Dec 25 '20 19:12 ov3rk1ll

what is the status of that? What needs to be done to get it out of WIP?

A simple bullet point list is enough 😉

colthreepv avatar Jan 17 '21 14:01 colthreepv

@colthreepv one of the main differences is the way to two apps approach browsing: quest-sidenoder provides a file browser that can work in any folder while vue-sidenoder only looks at the remote mount and expects folder with a certain naming scheme to work at all. While at it's core, both apps provide a similar feature set, the are more or less two different apps.

I'm working on a way to browse local files to also bring back that functionality.

There are no individual commits going from this app to vue-sidenoder as that was written completely new from scratch and this MR is just a (now outdated) rebase. While some of the initial code was taken from this repo, almost everything in vue-sidenoder is completely rewritten at this point.

This also makes the front- and backend of both apps completely incompatible.

I'm honestly not sure what the best approach would be to go forward about pulling some changes back into this repo without a full rewrite/rebase.

ov3rk1ll avatar Jan 18 '21 07:01 ov3rk1ll

In my opinion works indeed more smoothly than the original project, not requiring side installations

Simple APK install or Folder APK install are already supported, and I think this covers base needs for users

For local file browsing I would suggest a much simpler approach, just a switch toggle between remote/local.
Remote works with naming scheme, but local does not. just simple file manager.
If we want, we could implement a File manager Vue interface, and just write the necessary API(s) to browse local files, it would be a nice-to-have that can be added later on, and with not much work, leveraging the framework, not coding the entire filebrowser by hand.

I think the decision rests on @whitewhidow, my suggestion is again to merge this PR on a next branch, make a pre-release v1.0.0 version and pick it up from there, issues can be tracked for 0.x and 1.x separately (if desired)

Just here to push this useful project in one common repository, easier to keep updated, instead of 2 projects both with pros/cons

colthreepv avatar Jan 18 '21 17:01 colthreepv

Thanks for the rewrite @ov3rk1ll this looks and works really smoothly. I hope it gets merged somehow !

vikbez avatar Jan 23 '21 09:01 vikbez