rubycritic icon indicating copy to clipboard operation
rubycritic copied to clipboard

feature failure against Ruby head

Open faisal opened this issue 8 months ago • 1 comments

https://github.com/whitesmith/rubycritic/pull/492 and https://github.com/whitesmith/rubycritic/pull/493 both fail in the same place when testing against HEAD:

expected `rubycritic --version  --no-browser` to have output "RubyCritic 4.9.1\n"
but was:
   RubyCritic 4.9.1

   /home/runner/work/rubycritic/rubycritic/vendor/bundle/ruby/3.4.0+0/gems/childprocess-5.0.0/lib/childprocess.rb:7: warning: logger was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add logger to your Gemfile or gemspec.
Diff:
@@ -1,3 +1,5 @@
 RubyCritic 4.9.1
+

This feature is not related to any codepaths touched by the PRs (particularly the case of https://github.com/whitesmith/rubycritic/pull/493, which touched no code paths).

faisal avatar Jun 07 '24 16:06 faisal