rack-utf8_sanitizer icon indicating copy to clipboard operation
rack-utf8_sanitizer copied to clipboard

Remove '\u0000' from input when sanitizing null input

Open such opened this issue 1 year ago • 8 comments

such avatar Oct 28 '24 12:10 such

There's a lot of unrelated formatting chances so I won't reviewing the PR.

whitequark avatar Oct 29 '24 19:10 whitequark

@whitequark Aside from the formatting changes, do you have an issue with this change? Would like to use this gem for sanitizing but we also need to sanitize \u0000, and happy to put up a PR without needless style changes

zachyale avatar Dec 13 '24 19:12 zachyale

I haven't reviewed it due to the formatting changes. I haven't even used Ruby in almost a decade and I don't want to waste my time looking at a PR like this one.

whitequark avatar Dec 16 '24 15:12 whitequark

I haven't even used Ruby in almost a decade and I don't want to waste my time looking at a PR like this one.

It's OK, but maybe you should assign a new maintainer for this repo. If you're not sure who — open an issue for this.

AlexWayfer avatar Dec 16 '24 15:12 AlexWayfer

I'm aware of my options.

whitequark avatar Dec 16 '24 15:12 whitequark

@whitequark / @AlexWayfer - the PR has been updated to remove unnecesarry formatting changes. Can we get a review please?

zachyale avatar Dec 16 '24 21:12 zachyale

I understand the stated purpose, but I don't think this should be the responsibility of this library, and I don't think removing \\u0000 is even correct in the general case. (It is perfectly valid UTF-8, after all.)

even if it was optional as well?

such avatar Dec 17 '24 12:12 such

This has nothing to do with invalid UTF-8, so yes.

whitequark avatar Dec 17 '24 13:12 whitequark