Catherine comments

Results 1913 comments of


                                            Catherine

show doesn't have a handler for Uchar.t

Or maybe `Uchar.of_char '%c'` for printable and `Uchar.of_int 0x%04X` for non-printable...

show doesn't have a handler for Uchar.t

You can conservatively stick to ASCII. 0x20..0x7E?

show doesn't have a handler for Uchar.t

> > > > Sorry, can you expand on that? I mean, convert it to `int` and check that it's between `0x20` and `0x7E`. That should cover all printable ASCII...

show doesn't have a handler for Uchar.t

You need to skip `0x00` to `0x1F` inclusive, too.

show doesn't have a handler for Uchar.t

Oh sorry, I missed `Char.escaped`. You are right.

show doesn't have a handler for Uchar.t

Yes, I believe that is the right place to implement support for `Uchar.t`.

show doesn't have a handler for Uchar.t

Why not both? The stdlib/compiler changes will likely take a lot of time.

show doesn't have a handler for Uchar.t

@pmetzger I like the syntax.

Unused values when deriving show for private types

I think `[@@warning "-32"]` and `[@deriving pp]` both seem like good options; we can simply do both of them.

Unused values when deriving show for private types

@NathanReb As mentioned above in https://github.com/ocaml-ppx/ppx_deriving/issues/171#issuecomment-400598844, I think both `[@@warning "-32"]` and `[@deriving pp]` ought to be implemented. If you can do one of them, great!