Catherine

Results 1908 comments of Catherine

The main issue here is that `managed::ManagedMap` doesn't exist. It should be a generalized version of `SliceArpCache`, using a slice on heap-free platforms and a BTreeMap otherwise.

#51 also needs a ManagedMap.

There is now a `managed::ManagedMap`. Also, scratch what I said about FIFO buffers, that doesn't sound like a very good idea on reflection. I'm not actually sure what sort of...

Sounds reasonable, though I think `FragmentedPacket::rx_buffer` shouldn't be a `RingBuffer`.

I really like your proposal! With one exception though: > with some components unapologetically relying on std and alloc, while the others being no_std. I don't think any of smoltcp's...

> As best I can tell, this isn't really possible right now (though if it is, I'd be interested to hear!) You can use the TCP sockets with all underlying...

Well this doesn't work at all, what with the many `ManagedSlice::Owned` instances in your PoC code.

On top of that, I think you're doing too much at once. I'd like to see the split of EthernetInterface into multiple layers separately from adding routing; either of these...

I'm not happy about this. You're making smoltcp perform significantly worse for the use case it is primarily intended for, which is small embedded devices. I don't think this is...

> with handler types owning packet buffers and returning them in destructors Hmm, are you sure? That seems like potentially a waste of time; the scheme with `Drop` was a...