pelican-open_graph icon indicating copy to clipboard operation
pelican-open_graph copied to clipboard

Published 20 hours ago • verified publisher icon whiskyechobravo

og:image doesn't use SITE_URL

Open epaulson opened this issue 7 years ago • 2 comments

Not a huge issue, but if you set og_image in the header, it doesn't use SITE_URL - but if you let it default to the first image in the content, it does use SITE_URL. It'd be nice if the plugin used site_url and seems like it should to keep content portable.

To keep it from breaking every existing use, maybe it could check to see if the og_image tag starts with 'http' and if it does, don't use site_url, but if it doesn't, stick site_url on to the path?

epaulson avatar Sep 23 '17 03:09 epaulson

Hello, I don't know if your issue was opened in September of 2017 or 2016, but it looks like there was a code change to address this.

https://github.com/whiskyechobravo/pelican-open_graph/commit/ad4eaaf43f644db983a365f0375777f1fb1e26f9

Hopefully, this will be what you were looking for.

mandaris avatar Nov 06 '17 04:11 mandaris

Also, there is a pull request associated with this.

https://github.com/whiskyechobravo/pelican-open_graph/pull/13/commits/2892cbc9203a1e068e58dcbbc8b7840c7e343269

mandaris avatar Nov 06 '17 04:11 mandaris