whipper icon indicating copy to clipboard operation
whipper copied to clipboard

Path with multiple quotes (singles, probably doubles) raises exception

Open brboi opened this issue 5 years ago • 5 comments

When I have two or more quotes in the file path, whipper raises exception (in some subcommand, don't remember which one).

I was trying to rip https://musicbrainz.org/release/e37278c5-f0be-4caf-848c-b88da05b92c8

All whipper path filters were activated (posix, printable…)

Please provide a way to handle that :+1:

If you tell me how you would like to do so, I may create a PR ;-)

Best regards, Bruno

brboi avatar Jun 22 '20 16:06 brboi

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

github-actions[bot] avatar Jun 22 '20 16:06 github-actions[bot]

BTW, I can rip that CD by adding those lines to the PathFilter.filter method:

    # filter quotes
    path = re.sub(r"'", R_CH, path)
    path = re.sub(r'"', R_CH, path)

This is not a proper solution I can PR, obviously, but for me this do the trick while waiting your comments on this ;-)

brboi avatar Jun 22 '20 16:06 brboi

Hi, could you post the whole traceback related to this exception?

P.S.: Morricone RIP 😢

JoeLametta avatar Jul 08 '20 13:07 JoeLametta

@brboi Hi, could you post the whole traceback related to this exception?

JoeLametta avatar Sep 18 '20 08:09 JoeLametta

@brboi Ping

JoeLametta avatar Dec 26 '20 16:12 JoeLametta