whipper-team
Use user submitted MusicBrainz Data
If a cd is unknown at MusicBrainz you'd mostly got a problem like this:
[arch@arch Music]$ rip cd rip --offset 6 --track-template="%R/%A/%d/%t. %n" --disc-template="%R/%A/%d/%A - %d"
Checking device /dev/sr0
eject: CD-ROM tray close command failed: Input/output error
CDDB disc id: 4c12f916
MusicBrainz disc id kKrMj0RknVuwLKBn1Om8hwcJbu0-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+22+364477+150+15933+33032+46481+64238+81046+97359+114482+131698+147732+163788+181038+196001+211996+229416+247124+264883+282083+299542+317168+332494+349483&tracks=22&id=kKrMj0RknVuwLKBn1Om8hwcJbu0-
Disc duration: 01:20:57.693, 22 audio tracks
Continuing without metadata
Submit this disc to MusicBrainz at the above URL.
FreeDB identifies disc as Scooter / 20 Years Of Hardcore CD 01
However MusicBrainz offers you to enter the data youself without registration. That is not in the official database then, but (it looks to me) still available for everyone: https://musicbrainz.org/cdstub/kKrMj0RknVuwLKBn1Om8hwcJbu0-
If a user entered dataset could be read as alternative that'd be great. I've use the whipper archlinux package from aur, so I guess my musicbrainz is up to date. Maybe its an upstream issue of that module instead.
If a user entered dataset could be read as alternative that'd be great. I've use the whipper archlinux package from aur, so I guess my musicbrainz is up to date. Maybe its an upstream issue of that module instead.
I decided to handle it this way (ignoring CD stub entries) in order to follow the original design (only get trusted & complete information). That's the same way FreeDB is used to show disc information when not available in MusicBrainz but not actually used for the ripping process. Anyway it's not hard to sign up on MusicBrainz to add the details of an unknown CD as an official entry.
More details here: https://github.com/JoeLametta/whipper/commit/0a142036efbe46ea33631e4b8c83accc26d91aac
You could promt the user to use the "unofficial" entry. Also it would be nice if you do not need to rerun the command with -U and just ask the user to continue without tags.
Background: If you do not supply the tags while reading the .cue file and the playlist contains wrong filenames if you later rename/tag the files. Then its a struggle to get this correct again too. So if the quick "unofficial" method would work, that'd be great. Also because I simply do not want to sign up on thousands of services.
You could promt the user to use the "unofficial" entry.
Uhm... as I expect whipper to work in a batch fashion every active prompt requiring user input is a no go (maybe it could be automated through a config option). Keep in mind that the stub entries have a different structure (if compared to the regular releases) so, in order to implement this hypothetical feature, a specific code path will need to be implemented.
Also it would be nice if you do not need to rerun the command with -U and just ask the user to continue without tags.
That already works: just rip always with -U (or --unknown). You can also set it permanently into whipper's config file as shown here.
Uhm... as I expect whipper to work in a batch fashion every active prompt requiring user input is a no go (maybe it could be automated through a config option). Keep in mind that the stub entries have a different structure (if compared to the regular releases) so, in order to implement this hypothetical feature, a specific code path will need to be implemented.
At least a note like "no tags found, use the -U option to rip without tags" would be nice.
That already works: just rip always with -U (or --unknown). You can also set it permanently into whipper's config file as shown here.
Thats more comfortable but does not solve the problem. As I said all .cue files and playlists are broken if you rename the files. So beside a simple "wontfix" the suggested alternative musicbrainz comes to my mind or as an alternative an user interactive mode to type the titles (with a special command line option, not as default). However the last one is possibly harder to code and with the first one everyone can get the titles from other non registered users possibly. I think its up to you if you'd like to implement this type of feature.
At least a note like "no tags found, use the -U option to rip without tags" would be nice.
This one is a good idea.
Thats more comfortable but does not solve the problem. As I said all .cue files and playlists are broken if you rename the files. So beside a simple "wontfix" the suggested alternative musicbrainz comes to my mind or as an alternative an user interactive mode to type the titles (with a special command line option, not as default). However the last one is possibly harder to code and with the first one everyone can get the titles from other non registered users possibly. I think its up to you if you'd like to implement this type of feature.
I've got another (slightly different) idea: what about letting whipper pick up the cdstub results only when -U (or --unknown) switch is used? This way the default works as expected (in a non interactive way) and for the users who aren't afraid of getting absent or poor quality metadata, cdstub results are made available (not implemented at the moment).
I think we should still introduce a new parameters as you sometimes just want to have unknown rather than something completely wrong, or for other reasons we don't know yet. Choose whatever parameter is free and add a notice that you can try -U or -XYZ instead. And possibly explain that you can fill in the data online without an account.
Another thing I am still wondering about: My Car CD Player can read the cd information itself. And my car is not super smart, so I guess there must be some information on the disk itself. But why does the whole world need cd tag databases if the cd already provides most information? That be almost 100% relyable and super lazy/easy. https://en.wikipedia.org/wiki/CD-Text
I think we should still introduce a new parameters as you sometimes just want to have unknown rather than something completely wrong, or for other reasons we don't know yet. Choose whatever parameter is free and add a notice that you can try -U or -XYZ instead. And possibly explain that you can fill in the data online without an account.
OK.
Another thing I am still wondering about: My Car CD Player can read the cd information itself. And my car is not super smart, so I guess there must be some information on the disk itself. But why does the whole world need cd tag databases if the cd already provides most information? That be almost 100% relyable and super lazy/easy.
That happens because CD-Text has its own limitations, support isn't required by CDDA so very few CDs include that information and not all the CD players/writers support it.
I'm going to echo what I said in IRC: I am comfortable-with/ambivalent-with-regards-to whipper supporting cdstub downloads, but I think it should be a non-default option.
Enough people tag their music after ripping to break the default .cue sheets anyways to the point where I don't think that "ugliness" of -U + tagging is awful enough to start using cdstubs, especially since encouraging people to upload accurate data to musicbrainz is good, in my opinion.
CD-Text discussion should be factored out of here, and not to https://github.com/JoeLametta/whipper/issues/44 . Briefly, however, I'm not against having an optional, non-default flag to use CD-Text in tags eventually.
Enough people tag their music after ripping to break the default .cue sheets anyways to the point where I don't think that "ugliness" of -U + tagging is awful enough to start using cdstubs, especially since encouraging people to upload accurate data to musicbrainz is good, in my opinion.
That's my opinion too: whipper isn't a music tagger / cue editor.
CD-Text discussion should be factored out of here, and not to #44 .
@NicoHood If you're still interested in CD-Text, please open a separate issue.
It looks like cd texts are not well formatted for my cds. It would be still better to use an online database. I dont know why music brainz was chosen, but maybe other could also give some hits about missing cds. For musicbrainz however its nice to add entries wihout an account every simple, its just missing in whipper.
For musicbrainz however its nice to add entries wihout an account every simple, its just missing in whipper.
??
Compared to using other DB services MusicBrainz offers a simple way to add new tags without the need of creating a new account. Also downloading the tags does not require an account. However that is not implemented yet.
I think s/every/very/ was my original thought :D
Note that FreeDB stuff is slowly being outphased from MusicBrainz, and CD Stubs are kind of 3rd class citizens within MB already. I don't want to say that it's official word, but I think we'd (MetaBrainz/MusicBrainz) would appreciate pointing people towards making proper MB accounts and adding proper MB data over using an antiquated system such as the CD Stub one.
Note that FreeDB stuff is slowly being outphased from MusicBrainz, and CD Stubs are kind of 3rd class citizens within MB already. I don't want to say that it's official word, but I think we'd (MetaBrainz/MusicBrainz) would appreciate pointing people towards making proper MB accounts and adding proper MB data over using an antiquated system such as the CD Stub one.
Thanks for detailing CD Stub's status.
Verdict: this issue is a probable wontfix (or very low priority).