AndroidTagView icon indicating copy to clipboard operation
AndroidTagView copied to clipboard

Selected state for TagView

Open ralphilius opened this issue 8 years ago • 5 comments

I wonder if we can set selected state when we click on a TagView. Or at least, should we have getTagView(int position) method in the TagContainerLayout and an attrs to set TagView's background?

ralphilius avatar Apr 29 '16 06:04 ralphilius

Yeah, put some kind of state for TagView is a good suggestion! I think I will add this feature in next version. And there are some methods to get TagView's attribute, like getTagText(int position) method return the string text in a TagView, so I think it's not necessary to add getTagView(int position) method, and add an attr to set TagView's background, you mean set all TagView's background in one TagContainerLayout?

whilu avatar Apr 29 '16 13:04 whilu

add an attr to set TagView's background, you mean set all TagView's background in one TagContainerLayout?

Yes. That is what I suggest. Since TagViews are dynamically added to TagContainerLayout it is difficult to add different state color for each TagView. I have a local fork that has such functionality. If you want I can create a PR.

ralphilius avatar Apr 30 '16 19:04 ralphilius

Welcome to create PR, it's great! Thank you! 2016年5月1日 上午3:33,"Ralphilius" [email protected]写道:

add an attr to set TagView's background, you mean set all TagView's background in one TagContainerLayout?

Yes. That is what I suggest. Since TagViews are dynamically added to TagContainerLayout it is difficult to add different state color for each TagView. I have a local fork that has such functionality. If you want I can create a PR.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/whilu/AndroidTagView/issues/12#issuecomment-215989125

whilu avatar May 01 '16 02:05 whilu

@Ralphilius @whilu Any update on this? Thank you

sunnymopada avatar Oct 21 '16 06:10 sunnymopada

@Ralphilius did you submit the PR?

csbenz avatar Jan 01 '17 23:01 csbenz