Rhys Evans comments

Results 67 comments of


                                            Rhys Evans

Provide size classes and mixins for o-icons

I'd argue that providing icons at a size less than 128px is a pretty reasonable baseline requirement for an icon component, but the use case is ombudsman.in.ft.com

Support pseudo box style radio links within inline fields

Is this not a bug rather than a feature?

Incompatibility between build service and snapshotting pages

Can you point me at a public site using build service so I can raise an issue with chrome?

fallbackToNetwork does not work with relative URLs

I now have a 'fix' for this being rolled out in @fetch-mock/core https://github.com/wheresrhys/fetch-mock/pull/805

Typescript: FetchMockSandbox and native fetch have incompatible types

I won't be fixing this as I'm working on a totally new implementation, @fetch-mock/core, which does not have the `.sandbox()` functionality

TypeError: Invalid state: ReadableStream is locked error from fetch-mock router when combining AbortSignal.timeout and recursive retries

Hello 👋 Just getting round to looking at this now. Which version of jest are you on? I'm not able to get the test to fail, but I do keep...

TypeError: Invalid state: ReadableStream is locked error from fetch-mock router when combining AbortSignal.timeout and recursive retries

Here's an example of a failed test run https://app.circleci.com/pipelines/github/wheresrhys/fetch-mock/1065/workflows/d8562eee-0ff3-4dc2-8fde-14a9df91f744/jobs/11161

TypeError: Invalid state: ReadableStream is locked error from fetch-mock router when combining AbortSignal.timeout and recursive retries

Reading here https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream/locked I don't understand much more But I have a hunch that [your `.json()](https://github.com/wheresrhys/fetch-mock/compare/main...laurieboyes:fetch-mock:main#diff-ee4acfc8f5f94532279e0cfad10e16ac93d2db84a6e9c9404510acc9b6cc452eR15) reads and locks the body stream, which then causes the error because the streanm...

TypeError: Invalid state: ReadableStream is locked error from fetch-mock router when combining AbortSignal.timeout and recursive retries

Could you check out this https://github.com/wheresrhys/fetch-mock/pull/847, run `npm build` and then manually copy the files into your node_modules to see if the fix works (I'd offer to publish a beta...

TypeError: Invalid state: ReadableStream is locked error from fetch-mock router when combining AbortSignal.timeout and recursive retries

@RubenAWL What issue were you seeing exactly as I thought this discussion was only about cases when abort was used? Is there some other issue with readable streams that occur...