wheeheee
wheeheee
I took reference to [FastConv.jl](https://github.com/aamini/FastConv.jl/blob/master/src/utils.jl) (licensed under the "MIT License (Expat)") and wrote a version with an explicit loop over `CartesianIndices` for 1-based arrays (unsure about offset indices). Here it...
> I've implemented the keyword-argument-based algorithm selection. I'm not entirely sure I like it, but the first impression is okayish. If you're referring to the somewhat messy organization in `conv`,...
My opinion, for what it's worth: - I initially thought it possible in rare cases that the slower algorithm is chosen, or that it could be platform-dependent, so that it...
Sounds good. Another thought I had regarding commutativity and axes, while reading this after prematurely micro-optimizing the loop: even if we consider `*` potentially non-commutative, I suspect we could still...
I think the second option with `:auto` replacing the current default behaviour seems safer. Perhaps a simplified general-user-facing `conv(u, v; mode=:auto(/:unsafe_fast))` would be friendlier, with `:unsafe_fast` enabling conversion to floats...
Not sure what the detailed benchmarks say, but would it be acceptable to start with the conservative heuristic here since it's IIUC a definite improvement for small sizes? Also saw...
Just a side note that from 1.10 -> 1.11 the tests take something like 0.8x more time, which imo is a pretty serious performance regression. Can't be certain but probably...
Sounds good! Not familiar with package extensions, so maybe it would be better if there's another reviewer...
Yes, in addition to what @mbaz mentioned, I believe `filt` with `DF2TFilter` (or `filt!`, plus a 1-element `out` buffer) does what `_fit!` does, although it should be much better to...
> The documentation here is quite unhelpful, unfortunately: for example, the two definitions of `filt` [here](https://docs.juliadsp.org/stable/filters/#Filter-application) are ambiguous. I think type annotations within the docstring function definitions would be helpful?...