url icon indicating copy to clipboard operation
url copied to clipboard

"the substring from pointer in input"

Open GPHemsley opened this issue 8 years ago • 4 comments

#343 introduced the phrasing "the substring from pointer in input" to essentially check c and the first one or two characters in remaining.

I sort of raised this in a comment at the time, but I'm actually attempting to implement it now, and it's a little tedious, so I wanted to revisit: Is there a better way to phrase this, perhaps in a way that makes better use of the definitions in §1.2. Parsers?

GPHemsley avatar Oct 29 '17 08:10 GPHemsley

Relatedly, #343 claims to solve the remaining problem outlined in #308, but I'm not convinced that it does.

GPHemsley avatar Oct 29 '17 09:10 GPHemsley

We could make it "c concatenated with remaining".

annevk avatar May 04 '20 13:05 annevk

We could make it "c concatenated with remaining".

Before using remaining we need to checkc is not EOF. While "the substring from pointer in input" is just empty when c is EOF.

rmisev avatar May 04 '20 14:05 rmisev

Since substring is now defined I think this is clear enough.

annevk avatar Oct 09 '21 06:10 annevk