html icon indicating copy to clipboard operation
html copied to clipboard

Add a performance entry type for visibility state changes

Open noamr opened this issue 3 years ago • 2 comments

The entry is added when the visiblity changes for any reason, and an initial entry is added when the document becomes active.

See https://github.com/w3c/performance-timeline/issues/105 See also https://github.com/w3c/page-visibility/issues/29

This is the solution that was proposed at WebPerfWG (TODO add link to minutes) See Design review at CTAG

  • [ ] At least two implementers are interested (and none opposed):

  • [x] Tests are written and can be reviewed and commented upon at:

    • https://github.com/web-platform-tests/wpt/pull/35620
  • [ ] Implementation bugs are filed:

    • Chrome: 1103451
    • Firefox: …
    • Safari: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …

(See WHATWG Working Mode: Changes for more details.)


/browsers.html ( diff ) /index.html ( diff ) /infrastructure.html ( diff ) /interaction.html ( diff ) /references.html ( diff )

noamr avatar Aug 18 '22 13:08 noamr

LGTM. Needs the PR template filled out, and then we can merge.

Thanks! I'm still working on the WPTs :)

Somewhat favorable Mozilla position

I don't see any Mozillan positions in that thread?

You're right, I saw @dbaron's name (it's from the time when he was still at Mozilla) but it's W3CTag. @dbaron do you remember who from Mozilla was involved in this? /cc @emilio

noamr avatar Aug 24 '22 07:08 noamr

@sefeng211 does the performance team have any concern with this?

emilio avatar Aug 24 '22 08:08 emilio

Ping @sefeng211 for any opinions from Mozilla?

domenic avatar Apr 06 '23 07:04 domenic

This looks good from our side.

sefeng211 avatar Apr 06 '23 17:04 sefeng211

Thanks! @noamr I'll wait to merge this until you give the sign that you're ready to ship this in Chromium, and file appropriate Gecko/WebKit bugs. Also if you could fix the merge conflicts that would be lovely.

domenic avatar Apr 07 '23 03:04 domenic

Thanks! @noamr I'll wait to merge this until you give the sign that you're ready to ship this in Chromium, and file appropriate Gecko/WebKit bugs. Also if you could fix the merge conflicts that would be lovely.

On it. AFAICT the chromium implementation has been ready for a while, will double check and start the I2S thing etc. thanks!

noamr avatar Apr 07 '23 04:04 noamr