html
html copied to clipboard
whatwg
Define base appearance for <select>
This PR defines the base appearance except for the UA stylesheet for customizable select as proposed in https://github.com/whatwg/html/issues/9799
Base appearance is being defined in CSS here: https://github.com/w3c/csswg-drafts/pull/10691
- [x] At least two implementers are interested (and none opposed):
- Chrome
- Mozilla: https://github.com/mozilla/standards-positions/issues/1060
- WebKit: https://github.com/WebKit/standards-positions/issues/386
- [x] Tests are written and can be reviewed and commented upon at:
- https://wpt.fyi/results/html/semantics/forms/the-select-element/customizable-select/
- [x] Implementation bugs are filed:
- Chromium: Already implemented
- Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1944403
- WebKit: https://bugs.webkit.org/show_bug.cgi?id=286642
- [x] MDN issue is filed: https://github.com/mdn/content/issues/37857
- [x] The top of this comment includes a clear commit message to use.
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff ) /infrastructure.html ( diff ) /references.html ( diff ) /rendering.html ( diff )
Thanks for the review! I just pushed a lot of changes.
I'm missing the base appearance style sheet?
I have a separate PR for that here: https://github.com/whatwg/html/pull/10670
I can get rid of that PR and include it in this PR if you'd prefer.
I added paragraphs for opening the picker and moving focus between options
from whatnot:
- We should add paragraphs for home/end/pageup/pagedown with the picker open
- home/end/pageup/pagedown should not do anything while the picker is closed
- we should not actually reference home/end/pageup/pagedown explicitly in our abstractions, but we can add a note to the spec that these keys are typically what perform these actions
This PR won't be merged and will instead be included in a bigger PR including all customizable select PRs: https://github.com/whatwg/html/pull/10548