Silence Jake diagram conformance warnings on CI
What is the issue with the HTML Standard?
See discussion in https://github.com/whatwg/html/pull/10530.
When our spec builds on CI, we run the conformance checker. It gives the following "info warnings" for an intentional markup pattern we're using:
"file:/whatwg/output/index.html":64750.409-64750.412: info warning: A table row was 5 columns wide, which is less than the column count established by the first row (6).
"file:/whatwg/output/index.html":64750.513-64750.520: info warning: A table row was 5 columns wide, which is less than the column count established by the first row (6).
We should silence these so that they don't confuse contributors.
@sideshowbarker do you know how to do this? Probably by changing what we're passing to the conformance checker in https://github.com/whatwg/html-build/blob/a0a6276f117cfb11ee271e5956c032535885632c/ci-build/inside-container.sh#L14 ?
/cc @yoavweiss
What is a missing cell? HTML doesn't appear to define that concept. Although I guess it doesn't really say this is a model error either.
I think just like the Encoding standard we can use a .htmlcheckerfilter file to suppress these info warnings, but I'd like to first understand this better.
@sideshowbarker do you know how to do this? Probably by changing what we're passing to the conformance checker in whatwg/html-build@
a0a6276/ci-build/inside-container.sh#L14 ?
For the record here: We can do something similar to what we do here:
https://github.com/whatwg/whatwg.org/blob/f4844f60fc518ba4e644d5626ce90e3e3fa73773/deploy.sh#L57
…that is, given --filterpattern argument to the checker invocation, along with the right pattern. So it’d look like this:
java -Xmx1g -jar ./vnu.jar --filterpattern ".*which is less than the column count.*" --skip-non-html "$HTML_OUTPUT"
I think just like the Encoding standard we can use a
.htmlcheckerfilterfile to suppress these info warnings, but I'd like to first understand this better.
Ah yeah, if it’s already set up for that too.