html icon indicating copy to clipboard operation
html copied to clipboard

Session history step of top level navigable when child navigables traverse history

Open ADKaster opened this issue 2 years ago • 1 comments

What is the issue with the HTML Standard?

It's unclear to me looking at the canonical Jake diagram introduction whether the session history step of navigables that share a top level traversible are supposed to increment in lock-step, or if each navigable is allowed to increment its own step independently.

This relates to the new assertion added to apply the history step step 12.5

"push": Assert: targetEntry's step is displayedEntry's step + 1 and targetEntry's document state's ever populated is false.

I ran into a case in Ladybird tests where the session history step was incremented several times by an iframe, and then the top level traversible was navigated later. As far as I can tell, this is analogous to the example jake diagram I linked above.

In that test case, the displayed entry for the top level traversible was step "1", and the target entry was a new step "5". (where steps 2, 3 and 4 related to the iframe navigation only).

Is this a bug in my implementation, or is the spec assertion incorrect in this case?

cc @domenic @kalenikaliaksandr

ADKaster avatar Jan 29 '24 13:01 ADKaster

It's unclear to me looking at the canonical Jake diagram introduction whether the session history step of navigables

Can you say what you mean by "session history step of navigables"? Navigables aren't defined to have a session history step; only top-level traversables are.

domenic avatar Jan 31 '24 04:01 domenic