dom
dom copied to clipboard
AbortSignal's abort reason downstream integration
I somehow forgot that AbortSignal
is a pretty popular API these days. There's more than Fetch and Streams to update. For each impacted specification not only do we need to migrate away from the "aborted flag", we also need to make sure they take into account the object's abort reason, in a matter that is appropriate for the API.
- [ ] https://github.com/whatwg/fetch/pull/1343
- [x] https://github.com/whatwg/streams/issues/1165 & https://github.com/whatwg/streams/pull/1182
- [x] https://github.com/w3c/webauthn/issues/1682
- [x] https://github.com/w3c/web-nfc/issues/630
- [x] Web Bluetooth
- [x] https://github.com/WICG/app-history/pull/188
- [x] EyeDropper https://github.com/WICG/eyedropper-api/pull/25
- [x] Idle Detection https://github.com/WICG/idle-detection/pull/48
- [x] https://github.com/WICG/scheduling-apis/pull/53
- [x] https://github.com/WICG/web-locks/pull/86
- [x] Credential Management
- [x] Geolocation Sensor https://github.com/w3c/geolocation-sensor/pull/53
- [x] https://github.com/WICG/web-otp/issues/56
@domenic created a list of affected specs at https://github.com/whatwg/streams/issues/1165#issuecomment-920114795.
Thanks, added. If someone could file issues for those as a first step that would be appreciated.
I noticed it in Credential Management (https://github.com/w3c/webappsec-credential-management/pull/176), which you have. Thanks!
update 2021-11-11: this comment is now issue #1031; thus am hiding this comment as being off-topic here.
Original comment:
Might you folks be able to point at a more detailed example of how one's "abort steps" might signal to one's overall algorithm that it needs to "Stop doing amazing things." ?
I am guessing that one's abort steps could set a "stop doing things" flag, and one's overall algorithm's in-parallel steps could check that flag now-and-then and if true then one's spec would simply say to "abort these alg steps" (it wouldn't need to do the promise rejection at that point because the "abort steps" (per abortcontroller-api-integration) take care of it) ....?
@equalsJeffH I've moved your request to a new issue since it isn't related to this one (besides both being on the topic of AbortSignal): https://github.com/whatwg/dom/issues/1031
(FYI: Web Bluetooth was fixed in https://github.com/WebBluetoothCG/web-bluetooth/pull/565/commits/c7c0901a633639250e38e45ea3352ec75dbd6ec1)
I just filed a bug against WebOTP, can you update the tracking comment above? Thanks :heart:
I filed a bug for WebNFC at https://github.com/w3c/web-nfc/issues/630.
FYI: Geolocation Sensor was fixed in https://github.com/w3c/geolocation-sensor/pull/53 and Idle Detection was fixed in https://github.com/WICG/idle-detection/pull/48
There is also an ongoing PR for EyeDropper: https://github.com/WICG/eyedropper-api/pull/25
We finally landed the Fetch PR (https://github.com/whatwg/fetch/pull/1343) as well, so I think we can close this issue now :)
Huge success; great work everyone!!