dde
dde copied to clipboard
allow using both syntaxes for YAML array keys in VIRTUAL_HOST
normally, we use this synax:
storage:
container_name: example-storage
image: minio/minio:RELEASE.2022-01-08T03-11-54Z
environment:
- VIRTUAL_HOST=storage.example.test
if we use this array syntax, the certificate wont be generated becuase we use a grep for VIRTUAL_HOST=
https://github.com/whatwedo/dde/blob/master/commands/project/up.sh#L17
storage:
container_name: example-storage
image: minio/minio:RELEASE.2022-01-08T03-11-54Z
environment:
VIRTUAL_HOST: 'storage.example.test'
We should use YQ to read the environment variables.
@rugbymauri this could be solved with this change: https://github.com/whatwedo/dde/issues/28
bumped into this today... we should prioritize this because it will scare off new users
Resolved by https://github.com/whatwedo/dde/commit/6ac8779446a4564c08a35c8e102a7865d9e099ed