dde icon indicating copy to clipboard operation
dde copied to clipboard

allow using both syntaxes for YAML array keys in VIRTUAL_HOST

Open xarem opened this issue 3 years ago • 1 comments

normally, we use this synax:

    storage:
        container_name: example-storage
        image: minio/minio:RELEASE.2022-01-08T03-11-54Z
        environment:
            - VIRTUAL_HOST=storage.example.test

if we use this array syntax, the certificate wont be generated becuase we use a grep for VIRTUAL_HOST=

https://github.com/whatwedo/dde/blob/master/commands/project/up.sh#L17

    storage:
        container_name: example-storage
        image: minio/minio:RELEASE.2022-01-08T03-11-54Z
        environment:
            VIRTUAL_HOST: 'storage.example.test'

We should use YQ to read the environment variables.

xarem avatar Mar 16 '22 07:03 xarem

@rugbymauri this could be solved with this change: https://github.com/whatwedo/dde/issues/28

tuxes3 avatar Jun 09 '22 08:06 tuxes3

bumped into this today... we should prioritize this because it will scare off new users

s4mpl3d avatar Feb 28 '23 17:02 s4mpl3d

Resolved by https://github.com/whatwedo/dde/commit/6ac8779446a4564c08a35c8e102a7865d9e099ed

s4mpl3d avatar Feb 29 '24 12:02 s4mpl3d