whatsapp-play icon indicating copy to clipboard operation
whatsapp-play copied to clipboard

Published 20 hours ago • verified publisher icon whatsplay

Minimizing Browser Window

Open soumyashaw opened this issue 4 years ago • 11 comments

Issue that this pull request solves

Closes: #295

Proposed changes

Minimizes the Browser window for Terminal Chat mode

Types of changes

Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update (Documentation content changed)
  • [ ] Other (please describe):

Checklist

Put an x in the boxes that apply

  • [ ] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings

Other information

Tested the working on my system (Windows)

soumyashaw avatar May 17 '20 19:05 soumyashaw

Should I remove the whitespaces?

soumyashaw avatar May 20 '20 18:05 soumyashaw

@soumyashaw Remove whitespaces and resolve the conflicts

rpotter12 avatar May 20 '20 22:05 rpotter12

I don't understand the change needed. Could you give some insight @rpotter12

soumyashaw avatar May 21 '20 19:05 soumyashaw

I don't understand the change needed. Could you give some insight @rpotter12

To make code easily readable we follow some basic rules to write a good code like we use PEP8 to do it.

rpotter12 avatar May 21 '20 19:05 rpotter12

Codacy Here is an overview of what got changed by this pull request:


Complexity increasing per file
==============================
- wplay/terminal_chat.py  1

See the complete overview on Codacy

rpotter12 avatar May 22 '20 11:05 rpotter12

The changes you suggested are done.

soumyashaw avatar May 22 '20 18:05 soumyashaw

@rpotter12

soumyashaw avatar May 24 '20 10:05 soumyashaw

@soumyashaw I need to test it first. :)

rpotter12 avatar May 24 '20 19:05 rpotter12

This is not a good approach, in addition to being for windows only adds additional libraries. Pyppeteer has an option to hide the browser, the "headless" parameter must be set in this function below. Changes in the session manager will also be necessary, since it is necessary to show the browser when the user is not logged in.

https://github.com/rpotter12/whatsapp-play/blob/1d3103001b66c77e9aee82a386e224752ada6d05/wplay/utils/browser_config.py#L124

xandao-dev avatar May 30 '20 16:05 xandao-dev

I saw that part in Pyppeteer and that's why didn't use that as it won't serve the purpose.

soumyashaw avatar May 31 '20 11:05 soumyashaw

I saw that part in Pyppeteer and that's why didn't use that as it won't serve the purpose.

@soumyashaw Implement that solution which can be run in all platform.

rpotter12 avatar May 31 '20 12:05 rpotter12