drf-excel icon indicating copy to clipboard operation
drf-excel copied to clipboard

Should XLSXListField Support Nullable Values?

Open thomasmatecki opened this issue 2 years ago • 1 comments

Currently XLSXListField does not behave very nicely if prepping a value of None. This field corresponds to DRF's ListField, which does support allow_null=True.

    def prep_value(self) -> Any:
>       if len(self.value) > 0 and isinstance(self.value[0], Iterable):
E       TypeError: object of type 'NoneType' has no len()

It seems as though this field should nicely handle null (None) values. Happy to open a PR if folks agree.

thomasmatecki avatar Apr 25 '22 18:04 thomasmatecki

That sounds like a good idea to me. It should definitely handle None and return '' in that case.

rptmat57 avatar Apr 25 '22 19:04 rptmat57