integrated-manager-for-lustre icon indicating copy to clipboard operation
integrated-manager-for-lustre copied to clipboard

Published 20 hours ago • verified publisher icon whamcloud

Implement new automatic snapshot feature

Open ip1981 opened this issue 4 years ago • 10 comments

Signed-off-by: Igor Pashev [email protected]

This change is Reviewable

ip1981 avatar Nov 26 '20 13:11 ip1981

Web interface shows Failed to load resource: the server responded with a status of 502 () error, when I applied this build. image

nixuser avatar Dec 03 '20 16:12 nixuser

why do we have policy and interval in help output? is it overlapping functionality or it is different? SUBCOMMANDS: create Create a snapshot destroy Destroy the snapshot help Prints this message or the help of the given subcommand(s) interval Snapshot intervals operations list List snapshots mount Mount a snapshot policy Automatic snapshot policies operations retention Snapshot retention rules operations unmount Unmount a snapshot

nixuser avatar Dec 03 '20 16:12 nixuser

why do we have policy and interval in help output? is it overlapping functionality or it is different? SUBCOMMANDS: create Create a snapshot destroy Destroy the snapshot help Prints this message or the help of the given subcommand(s) interval Snapshot intervals operations list List snapshots mount Mount a snapshot policy Automatic snapshot policies operations retention Snapshot retention rules operations unmount Unmount a snapshot

It's a previous effort which will be replaced by this new feature. You can ignore it for now.

ip1981 avatar Dec 04 '20 10:12 ip1981

Web interface shows Failed to load resource: the server responded with a status of 502 () error, when I applied this build. image

It's probably due to database migrations. I guess it needs to be built from scratch after I resolve conflicts in this PR.

ip1981 avatar Dec 04 '20 10:12 ip1981

@ip1981 please rebase, this has conflicts on latest master.

jgrund avatar Dec 11 '20 16:12 jgrund

The db table is empty, which means the issue is cache not updating in warp-drive:

Screen Shot 2020-12-11 at 12 59 00 PM

jgrund avatar Dec 11 '20 18:12 jgrund

One change we need in this patch is a way to select the time to take snapshots when we bring up the modal.

We should be able to add a timepicker control after the fs selection dropdown here:

Screen Shot 2020-12-11 at 2 46 36 PM

We should be able to use an time input to do this without too much hassle on the front-end:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/time

The time of day selected will be sent to the manager and stored in the db. This in turn will determine when the selected snapshot policy runs.

jgrund avatar Dec 11 '20 19:12 jgrund

Some more things to implement:

  • Min snapshots are 2. Max snapshots are 32.
  • We need to schedule the snapshot cleanup window per-policy
  • Each interval scheduled must have the ability to specify when it will first run

jgrund avatar Dec 15 '20 18:12 jgrund

Some more things to implement:

* Min snapshots are 2. Max snapshots are 32.

Done at the DB level and in GUI.

* We need to schedule the snapshot cleanup window per-policy
* Each interval scheduled must have the ability to specify when it will first run

Done. First create a new snapshot if possible, then cleanup.

There are a couple of things to improve, but in general it's ready.

~~I might be hitting a bug in Chrome when an input event is not triggered when selecting a date.~~ Was with 81, ok with 87.

ip1981 avatar Dec 23 '20 13:12 ip1981

I will need https://github.com/whamcloud/integrated-manager-for-lustre/pull/2457 and https://github.com/whamcloud/integrated-manager-for-lustre/pull/2458

ip1981 avatar Feb 25 '21 11:02 ip1981