Kangping
Kangping
It looks like there are formatting error with your PR: https://github.com/openthread/ot-br-posix/actions/runs/5553833818/jobs/10171787035?pr=1940 Please run command `./script/make-pretty clang-format` to fix it locally.
notice that this warning comes from the third_party `libevent`. I tend to let it be. FYI, we are not using the latest `libevent` to be compatible with Android. There are...
This PR depends on https://github.com/openthread/ot-commissioner/pull/138.
@simonlingoogle I added a new API `CancelDiscoverBorderAgent` in `border_agent.hpp` to cancel discovery. Please review.
This PR is obsoleted since the mainloop is already encapsulated in method `Application::Run()`.
Will do after addressing issue https://github.com/openthread/ot-commissioner/issues/51.
yeah, noticed that! Thanks @gocarlos !
@gabekassel Thanks for reporting this issue. Could your help provide the information to reproduce the crash? Like: 1. your border router, and joiner device commit ID 2. network topology 3....
@gabekassel sorry for delayed updates. I tried with the BR and joiner commits and finished the commissioning process successfully without crash (I am also testing with Nexus 5X Android 8.1.0)....