wger icon indicating copy to clipboard operation
wger copied to clipboard

Justification of unordered lists

Open milotype opened this issue 2 years ago • 3 comments

Use case

On the website you use CSS-style text-align: justify; for ul lists. From a typographic point of view it looks bad and is not necessary.

Proposal

Don't use CSS-style text-align: justify; for ul lists.

Screenshots

  1. list with text-align justify list with text-align justify

  2. list without text-align justify.png list without text-align justify png

milotype avatar Jul 05 '23 16:07 milotype

@milotype Hi, I'd love to hear your suggestions for a solution. What are your thoughts on using padding or aligning the text to the left?

I'm eager to contribute to this issue. Could you please assign it to me and provide some guidance?

sanimkhan avatar Aug 17 '23 17:08 sanimkhan

@sanimkhan Please see my proposal above. Text sould be aligned according to the used language. Latin left, arabic (and maybe othere) right.

I cannot assign it to you - it's not my project! But you can allways fork the project, create your own (new) branch in your forke, make and commit changes in your branch where you find necessary and send a Pull request to "https://github.com/wger-project/wger/pulls".

Finally it's up to the project owner to accept or dismiss changes Pull requests.

Related to issue #1401.

Milo

milotype avatar Aug 18 '23 12:08 milotype

@milotype Got it, Thanks for your reply 👍

sanimkhan avatar Aug 20 '23 14:08 sanimkhan