wger icon indicating copy to clipboard operation
wger copied to clipboard

BMI calculator only takes cm for height even when Imperial units are selected in preferences

Open deddc23efb opened this issue 3 years ago • 2 comments

Steps to Reproduce

  1. ... Current version 2.1a3.dev0 docker
  2. ... enter the nutrition BMI calculator
  3. ...

Expected results: I expect the data entry in the BMI calculator to honour the units I select in the user preferences.

Actual results: The units are set to cm and dont allow imperial units to be used in the BMI calculation.

deddc23efb avatar Sep 20 '22 03:09 deddc23efb

Hello, would like to claim this issue. Thinking of having the input field take in feet and inches when the user has selected imperial units as its preference and then converting that to cm on the backend and making the same function calls that are currently made for cm in order to keep it consistent.

Please let me know your thoughts on this.

@deddc23efb @rolandgeider

bernardokoen avatar Nov 07 '22 01:11 bernardokoen

Hi @bernardokoen

Yeah, in general support for imperial units could be improved. Here we could show change the input based on the user preferences, always saving to cm seems like a good idea.

Additionally, this seems like a good opportunity to implement the page in react

rolandgeider avatar Nov 07 '22 10:11 rolandgeider