s3-objects-stream-zip-php icon indicating copy to clipboard operation
s3-objects-stream-zip-php copied to clipboard

Update guzzle and phpunit to latest version

Open diego-sorribas opened this issue 4 years ago • 2 comments

Hi! I needed to update guzzle to 7.0 to use it in my project and also I modified the constructor so it can accept a custom ArchiveOptions so I can set for example setSendHttpHeaders method. There is another option that is to pass an array and create the setters of ArchiveOptions inside de constructor.

I found very diffcult to test the constructor, inside s3Client method its makes a connection to S3 so without property key and secret its difficult to continue the flow.

diego-sorribas avatar Jun 07 '21 00:06 diego-sorribas

Any chance an update like this can get merged? Guzzle 7 is Laravel's default at the moment.

voicecode-bv avatar Feb 18 '22 18:02 voicecode-bv

Any change an update like this can get merged? Guzzle 7 is Laravel's default at the moment.

Yeap, I'll take a look.

giovanigenerali avatar Feb 19 '22 02:02 giovanigenerali