forgit icon indicating copy to clipboard operation
forgit copied to clipboard

Fish bug: some of the commands (glo, gss) don't work

Open radiden opened this issue 3 years ago • 8 comments

Check list

  • [x] I have read through the README
  • [x] I have the latest version of forgit
  • [x] I have searched through the existing issues

Environment info

  • OS
    • [x] Linux
    • [ ] Mac OS X
    • [ ] Windows
    • [ ] Others:
  • Shell
    • [ ] bash
    • [ ] zsh
    • [x] fish

Problem / Steps to reproduce

Run glo or gss in fish. Instead of getting fzf the shell hangs, after pressing random buttons the cursor disappears, until Ctrl+C is hit. Other commands seem to work fine.

Versions:

git version 2.36.0
fzf 0.30.0 (tarball)
fish, version 3.4.1

radiden avatar May 30 '22 17:05 radiden

can reproduce void linux & nix latest

endigma avatar May 30 '22 17:05 endigma

Hi @endigma ,

Thanks for the report!! Unfortunately I don't have a linux box to test and fix with, is there any way you could submit a PR if you get to the bottom of it?

On my OSX machine, these commands are working as intended. (see screenshots below)

$ git --version
git version 2.34.1
$ fish --version
fish, version 3.1.2
$ fzf --version
0.25.1 (brew)

glo: Screen Shot 2022-05-30 at 11 27 19 AM

gss: Screen Shot 2022-05-30 at 11 28 58 AM

cjappl avatar May 30 '22 18:05 cjappl

you should try https://github.com/lima-vm/lima

endigma avatar May 30 '22 18:05 endigma

I can reproduce that glo hangs under macos. I am using following versions:

fzf --version
0.30.0 (brew)

fish --version
fish, version 3.5.0

git --version
git version 2.36.1

jgoldhammer avatar Jun 20 '22 06:06 jgoldhammer

fzf --version
0.30 (devel)

fish --version
fish, version 3.4.1

git --version
git version 2.36.1

can reproduce still

endigma avatar Jun 20 '22 12:06 endigma

I would fully support a PR to help fix this! Unfortunately I can't repro so I am not of help. If anyone wants to step up, happy to help review 😄

cjappl avatar Jun 20 '22 21:06 cjappl

I faced the same issue after installation of oh-my-fish/plugin-grc. It overrides env command. As workaround I've excluded env to override by set -U grc_plugin_ignore_execs env

goncharov avatar Aug 31 '22 06:08 goncharov

I faced the same issue after installation of oh-my-fish/plugin-grc. It overrides env command. As workaround I've excluded env to override by set -U grc_plugin_ignore_execs env

This is the fix.

endigma avatar Aug 31 '22 15:08 endigma

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 02 '22 04:11 stale[bot]