mokapot icon indicating copy to clipboard operation
mokapot copied to clipboard

Feature/plugin arch

Open jspaezp opened this issue 2 years ago • 5 comments

@wfondrie Discussed here --> https://github.com/wfondrie/mokapot/issues/74

jspaezp avatar Oct 22 '22 01:10 jspaezp

Codecov Report

Merging #75 (a9c1321) into master (bf6c0cd) will increase coverage by 0.33%. The diff coverage is 88.46%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   84.43%   84.77%   +0.33%     
==========================================
  Files          18       19       +1     
  Lines        1555     1622      +67     
==========================================
+ Hits         1313     1375      +62     
- Misses        242      247       +5     
Impacted Files Coverage Δ
mokapot/plugins/__init__.py 83.33% <83.33%> (ø)
mokapot/mokapot.py 91.89% <88.88%> (-2.02%) :arrow_down:
mokapot/config.py 100.00% <100.00%> (+8.69%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 22 '22 01:10 codecov-commenter

@wfondrie I think it is good to go. LMK if documentation is clear enough

jspaezp avatar Oct 25 '22 17:10 jspaezp

Thanks @jspaezp! I'll finish taking a look at this and get it merged soon 🙏

wfondrie avatar Oct 28 '22 17:10 wfondrie

I just found a bug so it's cool if you leave it in the back burner until i fix it :)

jspaezp avatar Oct 28 '22 17:10 jspaezp

squashed the bug! LMK when you have time to take a look at it. Best -Sebastian

jspaezp avatar Oct 29 '22 08:10 jspaezp

WOOOOO!!!!

jspaezp avatar Dec 03 '22 00:12 jspaezp

https://github.com/wfondrie/mokapot/pull/75/files#diff-6151fdf965e98367b9c6839d44d8a3e197950da27dd77522ed67a1115af9624aL27-L28 This has to be modified as well ... I think

jspaezp avatar Dec 03 '22 00:12 jspaezp

Good catch - thanks! I'm working on fixing this.

wfondrie avatar Dec 03 '22 00:12 wfondrie

@wfondrie lmk if you want me to fix it :)

jspaezp avatar Dec 03 '22 00:12 jspaezp

@jspaezp - can you review these changes? Did I miss anything?

I dont think so, lets see if the tests agree with me :P

jspaezp avatar Dec 03 '22 00:12 jspaezp