mokapot
mokapot copied to clipboard
Feature/plugin arch
@wfondrie Discussed here --> https://github.com/wfondrie/mokapot/issues/74
Codecov Report
Merging #75 (a9c1321) into master (bf6c0cd) will increase coverage by
0.33%
. The diff coverage is88.46%
.
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 84.43% 84.77% +0.33%
==========================================
Files 18 19 +1
Lines 1555 1622 +67
==========================================
+ Hits 1313 1375 +62
- Misses 242 247 +5
Impacted Files | Coverage Δ | |
---|---|---|
mokapot/plugins/__init__.py | 83.33% <83.33%> (ø) |
|
mokapot/mokapot.py | 91.89% <88.88%> (-2.02%) |
:arrow_down: |
mokapot/config.py | 100.00% <100.00%> (+8.69%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@wfondrie I think it is good to go. LMK if documentation is clear enough
Thanks @jspaezp! I'll finish taking a look at this and get it merged soon 🙏
I just found a bug so it's cool if you leave it in the back burner until i fix it :)
squashed the bug! LMK when you have time to take a look at it. Best -Sebastian
WOOOOO!!!!
https://github.com/wfondrie/mokapot/pull/75/files#diff-6151fdf965e98367b9c6839d44d8a3e197950da27dd77522ed67a1115af9624aL27-L28 This has to be modified as well ... I think
Good catch - thanks! I'm working on fixing this.
@wfondrie lmk if you want me to fix it :)
@jspaezp - can you review these changes? Did I miss anything?
I dont think so, lets see if the tests agree with me :P