mokapot icon indicating copy to clipboard operation
mokapot copied to clipboard

[Upgrade] Use pytest-datadir to manage data files for tests

Open wfondrie opened this issue 3 years ago • 2 comments

@jspaezp suggested switching over to pytest-datadir for managing our test data. This would have the benefit of simplifying our test fixtures, making it easier for folks to contribute. The user impact of this change is minimal, but it does add an additional developer dependency.

I think this change is probably worth making.

wfondrie avatar Jul 15 '21 19:07 wfondrie

I think i could tackle this issue but I feel like the cross linking PSMs PR should be solved first ... but if you want to set that aside and re-base it with the new test stuff i could go ahead and start the changes.

Best! Sebastian

jspaezp avatar Jul 26 '21 04:07 jspaezp

Unfortunately, cross-linking support has been kicked down the road a bit, so you shouldn't worry about. If you want to tackle the test conversion to pytest-datadir, please feel free to go ahead!

wfondrie avatar Jul 26 '21 23:07 wfondrie