vue-strap icon indicating copy to clipboard operation
vue-strap copied to clipboard

Modal not showing data - only undefined

Open webnoob opened this issue 9 years ago • 11 comments

I have the following:

<modal title="Make Payment" v-model="modelProp.value">
  <div slot="modal-header" class="modal-header">
    <h4 class="modal-title">Make a payment</h4>
  </div>
  <div>
    <p>Make a payment</p>
    <input type="text" v-model="paidAmount"/>
  </div>
</modal>

And when I click my button to trigger the modal, I get the modal itself show and the background fade out however, the content shows "undefined, undefined, undefined". This was working a few days ago and the only thing I can see that has changed is that I've done a fresh npm install so have the latest build now.

This is what shows:

image

This the element source:

<div role="dialog" class="modal in" style="display: block;">
  <div role="document" class="modal-dialog">
    <div class="modal-content">undefined undefined undefined</div>
  </div>
</div>

Any clues?

webnoob avatar Jan 01 '17 08:01 webnoob

I'v just noticed from this thread: https://github.com/wffranco/vue-strap/issues/31 that it's been advised to update to the later version of vue. I'm trying this now to see if it helps my issue.

EDIT: It doesn't help. I'm now running vue 2.1.8 and the issue remains. Unfortunately, I don't know which version I was running when it was working properly but it would have been from the middle of last week I believe.

webnoob avatar Jan 01 '17 08:01 webnoob

@webnoob This is caused by the normalization bug https://github.com/vuejs/vue/pull/4572/files

It's affecting multiple components, fix is coming with the 2.1.9 release. For now downgrade your vue and vue-template-compiler to 2.1.6

gholol avatar Jan 02 '17 14:01 gholol

@gholol Thanks for that, it appears to have fixed the issue.

webnoob avatar Jan 02 '17 16:01 webnoob

@webnoob @gholol FYI I've just updated to 2.1.9 and the problem persists.

dontfeedthecode avatar Jan 17 '17 08:01 dontfeedthecode

Are we sure this is a problem with Vue and not with vue-strap in that case? Has something changed in the latest vue version which requires changes within vue-strap?

webnoob avatar Jan 17 '17 10:01 webnoob

I can confirm this issue is still persistent in 2.1.10 ... #41

poppabear8883 avatar Jan 18 '17 19:01 poppabear8883

@webnoob

Are we sure this is a problem with Vue and not with vue-strap in that case?

Yes because it works as soon as you downgrade to 2.1.6

gholol avatar Jan 20 '17 18:01 gholol

That just means that the code in vue-strap works with the code in vue 2.1.6 not that vue has changed something that it's not intending to fix and vue-strap also needs to adhere to that change.

webnoob avatar Jan 20 '17 18:01 webnoob

@gholol @webnoob see #43 #41 .. needs a new build

poppabear8883 avatar Jan 20 '17 18:01 poppabear8883

last build with vue 2.1.10

wffranco avatar Feb 10 '17 15:02 wffranco

Still present in vue 2.3.2 and vue-strap 2.0.0beta1

stefanoborini avatar May 09 '17 10:05 stefanoborini