koparka icon indicating copy to clipboard operation
koparka copied to clipboard

Python 3 Support

Open leotada opened this issue 7 years ago • 4 comments

This needs a Python 3 support. I can help.

leotada avatar Feb 22 '18 14:02 leotada

I done this here: https://github.com/leotada/koparka/tree/py3

leotada avatar Feb 22 '18 21:02 leotada

I will accept pull requests, but please make sure it will still work on py2. So I'd rather see basestring defined as basestring=str on py3 then just replacing basestring with str. I'm also not 100% sure how py2 likes explicit relative imports - I've seen 2to3 add leading dots to the imports in demo.py, but demo.py is not part of a package, you should not import it, just run it, so I don't think the relative imports are needed here.

wezu avatar Feb 23 '18 08:02 wezu

https://github.com/wezu/koparka/pull/14

leotada avatar Jun 10 '18 18:06 leotada

It looks good, I don't see anything that should make problems, but I admit I haven't yet tested it on py 2.7 and py 3.6.

wezu avatar Jun 10 '18 19:06 wezu