wezterm icon indicating copy to clipboard operation
wezterm copied to clipboard

Contributing.md doesn't mention how to build on Windows

Open corbob opened this issue 7 months ago • 1 comments

What page or section of the docs have an issue?

https://github.com/wezterm/wezterm/blob/main/CONTRIBUTING.md

Describe the issue

I was attempting to build on Windows, and encountered an error regarding dlltool not being found. In searching the issues for Windows build information, I found a link to the Install from source docs, which I believe will get me where I need. It would likely be beneficial to link to this docs page from the contributing.md file.

Note: I am more than happy to provide updates to both the contributing.md file and the install from source docs. I am currently standing up a mostly fresh VM that I can validate setup steps on.

corbob avatar Jun 05 '25 15:06 corbob

This is partly just for my information, but may help others, or may help in enhancing both the contributing file and install from source docs. The following is all done using Chocolatey CLI.

Initially I installed the rust package. This seems to have installed rust, and possibly an older version of rust? I did not have rustup on the path, or even on the system. When I ran cargo check in the repository, it went through a bunch, and then couldn't find dlltool.exe. The error may have been helpful, or it might not have, I don't recall 😬. I do recall it was for getrandom.

On a fresh VM I ran: choco install rustup.install strawberryperl git -y, the rustup.install package seems to have set the correct runtime for rust info: default toolchain set to 'stable-x86_64-pc-windows-msvc', I then ran cargo check in the repository. This got further, but still had an error:

Image

With that, I ran choco install visualstudio2022community visualstudio2022-workload-nativedesktop -y to install Visual Studio with the correct (I think) workload. After that cargo check completed successfully.

corbob avatar Jun 05 '25 16:06 corbob