wezterm icon indicating copy to clipboard operation
wezterm copied to clipboard

Add a CloseWithoutClear copy mode key assignment

Open LeszekSwirski opened this issue 1 year ago • 5 comments

Closing the copy overlay currently unconditionally clears the viewport, in particular resetting scroll. For the search overlay, we don't necessarily want to scroll back to the prompt after finding a match -- indeed, the old search overlay (which didn't use copy mode) had this behaviour.

Add a CloseWithoutClear key assignment which has this desired behaviour, and make it the default for ESC in search mode.

LeszekSwirski avatar Feb 01 '24 09:02 LeszekSwirski

This fixes #3502

LeszekSwirski avatar Feb 01 '24 09:02 LeszekSwirski

Added a helper and dropped ResetViewport, PTAL (and let me know if you prefer me to squash the individual commits)

LeszekSwirski avatar Feb 05 '24 07:02 LeszekSwirski

Ping

LeszekSwirski avatar Feb 19 '24 09:02 LeszekSwirski

Ping again (@wez)

LeszekSwirski avatar Feb 27 '24 09:02 LeszekSwirski

@wez anything more to do here?

LeszekSwirski avatar Apr 04 '24 08:04 LeszekSwirski

Regular ping for review, @wez

LeszekSwirski avatar Jul 22 '24 12:07 LeszekSwirski

Thank you!

wez avatar Jul 22 '24 15:07 wez