wezterm icon indicating copy to clipboard operation
wezterm copied to clipboard

Add a new config setting that enable to change cursor's height.

Open ekil1100 opened this issue 1 year ago • 8 comments

Is your feature request related to a problem? Please describe.

N/A

Describe the solution you'd like

Currently, the cursor's height is equal to line height. When I change the line height to 1.8, the cursor changes too.

line_height = 1.8

CleanShot 2022-12-21 at 16 41 58

line_height = 1.2

CleanShot 2022-12-21 at 16 43 24

The cursor should not depend on line height, it looks weird.

Solution 1:

Add a new config setting that enable to change cursor's height.

Solution 2:

The cursor's height should depend on font size. So set cursor's height default to font size (maybe and 1 or 2 pixels to make it looks comfortable).

Describe alternatives you've considered

N/A

Additional context

N/A

ekil1100 avatar Dec 21 '22 08:12 ekil1100

Option where we can customize the cursor height while the cell(line) height not get affected. something like following


-- line height (this already exist)
config.line_height = 1.2  

-- cursor height ( enhancement )
config.cursor_height = "14px"

Adam-Al-Rahman avatar Jun 05 '23 08:06 Adam-Al-Rahman

In main, we now always render the text cursor at the native cell size.

It typically takes about an hour before commits are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer.

Please take a few moments to try out the change and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs.

If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a .dmg file on macOS, a .zip file on Windows and an .AppImage file on Linux) that can be run without permanently installing or replacing an existing package, and can then simply be deleted once you no longer need them.

If you are eager and can build from source then you may be able to try this out more quickly.

wez avatar Aug 26 '23 21:08 wez

But what about the people who liked the scaled-by-line-height-and-cell-width cursor ? I always have custom line height size and the cursor looks terrible if it isn't the same height as line height. Add some settings please, I don't want to look at this ugly cursor

Libsod avatar Jan 28 '24 12:01 Libsod

Due to overwhelming and sometimes toxic feedback, I've reverted this change from the nightly. I have no plans to look at this again; I have no energy to deal with toxic and entitled feedback.

If the community really wants this feature, they will need to step up and contribute.

wez avatar Feb 03 '24 18:02 wez

@wez Thank you for all of the incredible work you do for this project and for handling entitled feedback with patience rather than anger! You are a huge reason I (and probably many others) use WezTerm over kitty, Alacritty, and others (although it being an amazing piece of software also helps).

carschandler avatar Feb 05 '24 14:02 carschandler

@wez Thank you for all of the incredible work you do for this project and for handling entitled feedback with patience rather than anger! You are a huge reason I (and probably many others) use WezTerm over kitty, Alacritty, and others (although it being an amazing piece of software also helps).

I agree. Thank you @wez so much for ur amazing terminal

Libsod avatar Feb 05 '24 16:02 Libsod

@wez Thank you for all of the incredible work you do for this project and for handling entitled feedback with patience rather than anger! You are a huge reason I (and probably many others) use WezTerm over kitty, Alacritty, and others (although it being an amazing piece of software also helps).

I agree. Thank you @wez so much for ur amazing terminal

erm... From my perspective, your previous comment could easily be a contribution to the load that's breaking Wez's back...

"Add some settings please, I don't want to look at this ugly cursor"

The tone of this just sucks. A cross-platform terminal emulator with a multiplexer is no small amount of work, mate... And the change was anyway in response to a desired feature...

tjex avatar Feb 06 '24 14:02 tjex

I appreciate the sentiment, but each additional comment here uses more of my time just to remind me of how unpleasant some comments can be.

Please: constrain further comments here to technical concerns around designing and solving this; I have no interest in finger pointing or other commentary on how things went down.

wez avatar Feb 06 '24 17:02 wez