wezterm icon indicating copy to clipboard operation
wezterm copied to clipboard

Wayland version looks out of place with the rest of the desktop — missing window shadows

Open 1player opened this issue 2 years ago • 11 comments

What Operating System(s) are you seeing this problem on?

Linux Wayland

WezTerm version

wezterm 20220424-164129-3dfe7536

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

Tested on Fedora 36 GNOME

When Wayland is enabled, the window doesn't have the same drop shadow as all other applications have, and looks out of place.

To Reproduce

  • Enable Wayland

Configuration

enable_wayland=true

Expected Behavior

The wezterm window to have the same drop shadow as all other apps.

Logs

No response

Anything else?

wezterm on the left, GNOME Terminal on the right

image

1player avatar May 10 '22 09:05 1player

Don't quote me on that, but AFAIK libdecor should help to render client-side decorations that match the desktop.

1player avatar May 10 '22 10:05 1player

Wayland is weird like this!

If libdecor can improve things, then we're waiting on either one of:

  • https://github.com/Smithay/client-toolkit/issues/196
  • https://github.com/cmeissl/libdecor-rs

to be ready before we can start to investigate how to integrate this.

Otherwise: it is a non-goal for wezterm to directly try to match the gnome/gtk look.

wez avatar May 10 '22 13:05 wez

@wez I wouldn't call not-matching GTK style a bug. Alacritty and some other applications look different as well If GNOME really wanted all applications to have the same window decorations, they wouldn't advocate CSD and implement Server Side Decorations. This probably looks standard in the Wayland compositors that support SSD.

VarLad avatar May 17 '22 22:05 VarLad

any chance to have wezterm decorate its own shadow border? this is headache when i use alacritty on swaywm.

tmpm697 avatar Aug 27 '22 04:08 tmpm697

@tmpm697 I have no plans to do anything about this directly in wezterm. I'm waiting on the issues I mentioned above before coming back to this issue.

wez avatar Aug 27 '22 05:08 wez

There seems to be a GTK plugin implemented in libdecor, but there hasn't been a new release since. ~~I managed to give it try by compiling libdecor using this aur package, and then by running following command, I got the GTK 3 window style:~~

WAYLAND_DISPLAY=wayland-1 GTK_THEME=adwaita wezterm

arashm avatar Jun 19 '23 22:06 arashm

@arashm I think you're using XWayland there. As far as I understand it, you will need to modify either wezterm or SCTK to teach them to link to libdecor and cooperatively enable its decoration feature. If you haven't done the work for that, I don't see how it would change any behavior in wezterm.

wez avatar Jun 19 '23 23:06 wez

You can prove/disprove this by opening the debug overlay (CTRL-SHIFT-L) and looking at the Window Environment line. It will tell you whether it is using X11 or Wayland.

wez avatar Jun 19 '23 23:06 wez

@wez I see. I think you're right. Sorry for that.

arashm avatar Jun 20 '23 00:06 arashm

I know that this is not for everyone and I hope it's not regarded as useless noise, but the Rounded Window Corners GNOME extension adds a shadow to wezterm. If the lack of a shadow is a dealbreaker, this extension can be used to bridge the gap until there is a proper fix.

martijk avatar Aug 13 '23 07:08 martijk