wagmi icon indicating copy to clipboard operation
wagmi copied to clipboard

Fixes address comparison in getConnectorClient

Open razgraf opened this issue 1 year ago • 2 comments

Description

This PR implements a fix for the checksum comparison discussed in #3598.

It applies a checksum in getConnectorClient before verifying if the account is included in those authorized by the connector. It also updates the related test by formatting the expected address.

Tested locally and transactions now go through even when feeding a non-formatted address to writeContract.

razgraf avatar Feb 16 '24 11:02 razgraf

⚠️ No Changeset found

Latest commit: 05caefd8e68cd943de90f1d190b2a09a9a27e5d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 16 '24 11:02 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 11:19am

vercel[bot] avatar Feb 16 '24 11:02 vercel[bot]

Wasn't able to push so created https://github.com/wevm/wagmi/pull/3763. Added your changes so you still get credit.

tmm avatar Mar 27 '24 16:03 tmm

Thank you @tmm. Sorry for missing the "allow edits" checkbox.

razgraf avatar Mar 27 '24 20:03 razgraf