viem icon indicating copy to clipboard operation
viem copied to clipboard

fix(EIP712): do not allow extraneous attributes

Open freemanzMrojo opened this issue 11 months ago • 4 comments

Added a test with what I mean, title is self-explanatory.

freemanzMrojo avatar Jan 13 '25 10:01 freemanzMrojo

@freemanzMrojo is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 13 '25 10:01 vercel[bot]

⚠️ No Changeset found

Latest commit: 8ae7c5211e337b030b376c638c988098f2d29b20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 13 '25 10:01 changeset-bot[bot]

Hi @jxom , hope you had a good weekend!

Please, let me know if I should do something else, thanks!

freemanzMrojo avatar Jan 20 '25 10:01 freemanzMrojo

Hey @jxom , hope you are doing well! If you think I should close this PR, please let me know 🙏 . Thanks!

freemanzMrojo avatar Feb 13 '25 15:02 freemanzMrojo

I might close this PR for now as the type-system should pick up these issues, and extraneous attributes don't lead to incorrect hashes.

jxom avatar May 24 '25 06:05 jxom