wet-boew-styleguide
wet-boew-styleguide copied to clipboard
wet-boew
Expand/collapse w/ headers
I got the email update that we can use header levels in summary to fix the outline issues, but I think some email recipients misinterpreted the point of the email. Some seem to have taken it as "now we can have different sizes of expand/collapse".
I think it brings up a good question: Do we want expand/collapse summary text size to change depending on the header level inside of it?
@bsouster That's a good question.
I don't think all expand/collapse summary text must be the same size, as it would depend on the context, but I think for the most part if headings are used there should be a CSS class override to visually change the summary text back to the default size
I'm not sure bringing the font text down is always a good idea but I agree that it should be controlled via CSS classes.
Whatever the resulting summary size, we need to make sure the arrow and the heading text are the same size (so grow the arrow or shrink the text). We should be careful about decreasing the size though as if the summary element ends up as the same size as the related text then the understanding that it is a heading as well would likely be lost.
Is there any progress on how headered summary should display? We have clients trying to have us bold them. We'd rather wait until something is released than to put bandaids everywhere.
@rubinahaddad
@bsouster Nothing has been decided in terms of the visual style of headings. My question is what would be the reason you wouldn't want the collapsible to look like a heading (Size and weight) if it is a heading?
Please see the update here: https://github.com/wet-boew/wet-boew/issues/4965
This is now part of the style guide here in Alerts somewhat because of the Dismissible alerts.
Housekeeping: can this issue be closed? cc/ @bsouster @rubinahaddad @LaurentGoderre @pjackson28
