GCWeb
GCWeb copied to clipboard
Page feedback tool: Polish AJAX fragments (FR pageData, role="status")
The AJAX fragments had two minor flaws:
- The English fragment contained
pageData
references that were missing from the French variant. That difference caused a hiddeninput
named "contact" (with a JSON string as its value) to be injected into French feedback widgets. Although it didn't cause any other issues (data-feedback-link
anddata-feedback-url
still worked fine in practice). - The no
button
's invisible transition message in JS mode is technically a status message, but wasn't coded as such (was usingaria-live="polite"
as opposed torole="status"
).
This resolves the flaws by:
- Adding
pageData
references throughout the French fragment (same spots as English) to eliminate the hidden "contact"input
. - Replacing
aria-live="polite"
withrole="status"
in the nobutton
's transition message:-
role="status"
is a more formal way of denoting status messages, implicitly setsaria-live="polite"
+aria-atomic="true"
and is already in use for the widget's thank you message.
-