GCWeb icon indicating copy to clipboard operation
GCWeb copied to clipboard

Update and-or.css

Open Christopher-O opened this issue 1 year ago • 1 comments

updated line/border from background-image to border-image in order for line to show up better in high contrast mode.

Christopher-O avatar Apr 15 '24 21:04 Christopher-O

as discussed,

  • [x] Create a page with the French translation of the working example
  • [ ] Produce an accessbility assessment and upload it to the project experimental folder.
  • [x] Seperate the Working example vs the Guidance.
  • [ ] Cross-link all the project pages and documents to ensure we can find all the information published via our GCWeb website.

After we will work togeter to move out this experimentation into the stable space in the GCWeb product. Thanks

duboisp avatar Apr 18 '24 14:04 duboisp

Pre-approved upon successful review and completion of all work items.

Garneauma avatar Jun 10 '24 13:06 Garneauma

Waiting for @duboisp for conversion of WCAG accessibility points to HTML, unsure exactly what this task entails "Cross-link all the project pages and documents to ensure we can find all the information published via our GCWeb website." @Garneauma could you please advise?

Christopher-O avatar Jun 10 '24 14:06 Christopher-O

Comment regarding the adaptive style for the high contrast mode,

@media (prefers-contrast: more) {

I tested that CSS and my testing showed it acceptable in our currently supported browser list.

The supported browser are:

  • Chrome (Desktop and mobile)
  • Safari (Desktop and mobile)
  • Edge (Desktop only)

Here my test result in high contrast mode:


Windows Chrome: work as expected

xs-chrome


Windows Edge: work as expected

Same visual as Windows Chrome


Windows Firefox dev: It is broken, the user can not clearly read the conjunction word "and" and "or" because there is a vertical black bar in the middle

xs


MacOS Big Sur Chrome: Don't work as expected, but the text is readable, the white border gradient only affect the circle around the word, not the word itself.

Screen Shot 2024-06-18 at 9 35 49 PM

MacOS Big Sur Safari: Don't work as expected, but the text is readable, the white border gradient only affect the circle around the word, not the word itself.

Same visual as MacOS Big Sur Chrome


Here what it look like in normal mode

image


duboisp avatar Jun 19 '24 02:06 duboisp

@ouafaaetta as discussed, please submit a request change to the little update required in the accessibility report in JSON-LD. Thanks

duboisp avatar Jun 19 '24 14:06 duboisp

Completed the review and local testing, everything look good. There is a few typo change to apply prior to merge.

Note that some additional change would be required, post merge like:

  • Use jekyll front-matter to link the other page language
  • Adding the 2 HTML placeholder page to render the accessibility assessment in an HTML format.
  • Producing the index.json-ld file for documentation by leveraging the documentation provided.

duboisp avatar Jun 19 '24 15:06 duboisp

Changes in the PR

  • Changed border to appear in high contrast
  • Changed font size of CSS generated text to em value for better scalability between parent font sizes
  • Increased miminum height of side by side pattern to create consistant border above and below CSS text design
  • Updated governance towards stabilization

Impact for department

  • No change from a departmental perspective

Impact for the public

  • Allows border to be shown in high contrast (could require additional adjustment for FF and MacOS browsers)
  • Fixed issue of using design in font sizes other than 20px (GCWeb standard)

Christopher-O avatar Jun 19 '24 21:06 Christopher-O