GCWeb icon indicating copy to clipboard operation
GCWeb copied to clipboard

Create meli-melo 2022-05-tokens

Open delisma opened this issue 3 years ago • 2 comments

This pull request is to experiment GCDS design tokens

delisma avatar May 24 '22 19:05 delisma

As discussed: https://github.com/wet-boew/GCWeb/blob/master/sites/theme.scss#L44-L48

duboisp avatar Jun 07 '22 17:06 duboisp

Just wondering if there's an estimated release timeline for this? Would it be better to resurrect #1684 instead?

My concern is that to this day there still isn't a "proper" way of creating standard-looking forms in GCWeb (over 4 years after its fonts were reworked in 2019). I'm not thinking about specialized components like fieldflow or the giant checkbox/radio button classes.

Anyone that tries creating "standard" forms in GCWeb that follow WET's form validation plugin examples and/or use Bootstrap 3.4's form CSS patterns are pretty much guaranteed to end up with tiny-looking forms.

Partial/Temporary workarounds like the gc-font-2019 class aren't very ideal since they have a very narrow scope and are likely to produce a strange mix of tiny and normal-sized form presentations. Buttons are even worse off (only way of getting properly-sized buttons is to deliberately misuse larger button classes or call to action buttons).

I guess the point I'm trying to make is that the piecemeal approach that's been used for forms in GCWeb up to this point isn't really working out... and I don't think it's due to lack of demand (this PR is the 4th attempt to deal with it after @jkshapiro tried in #1654 / #1676 and mine in #1684).

Thoughts?

EricDunsworth avatar Aug 01 '23 22:08 EricDunsworth