GCWeb icon indicating copy to clipboard operation
GCWeb copied to clipboard

Bubble: Extract bubble from chatwizard

Open Ricokola opened this issue 4 years ago • 5 comments

Closes: #1730 and #1725 Related to: WET-131

Ricokola avatar Jun 04 '21 12:06 Ricokola

@Ricokola can you remove the merge commit and resolve the merge conflict

duboisp avatar Jun 09 '21 14:06 duboisp

@GormFrank I think everything has been covered from the suggested changes so please review and let me know if there is anything missing.

Ricokola avatar Jul 23 '21 12:07 Ricokola

@Ricokola @GormFrank To do:

  • [x] Skip link will be an anchor that brings to the bubble at all use case, never a button (this allows us to avoid fixing the button as part of the skip links as it is not needed);
  • [x] Share the components.json so it can be added to PR.
  • [x] Final build and test;

GormFrank avatar Jul 28 '21 14:07 GormFrank

@GormFrank ready for final review and approval!

Ricokola avatar Sep 07 '21 18:09 Ricokola

@Ricokola Here is the components.json file!

GormFrank avatar Sep 09 '21 18:09 GormFrank