GCWeb icon indicating copy to clipboard operation
GCWeb copied to clipboard

Build: Remove provisional task/rules/conditions/CSS

Open EricDunsworth opened this issue 5 years ago • 2 comments

Reasoning:

  • This task generated modified copies of all top-level pages within a /provisional/ folder.
  • The only obvious difference in affected pages was that their headers appeared to be broken.
  • Building 78 fewer pages (156 if unmin is counted) is likely to slightly speed up GCWeb's build system.
  • The cndwrdmrk class from the removed handlebars condition was only used in provisional page templates. Looks like an old experiment whose goal was to inject the Canada wordmark via CSS.

Notes:

  • None of these changes affect the /xprmntl/ folder's pages.
  • Related to a discussion in #1677.

EricDunsworth avatar Jun 04 '20 21:06 EricDunsworth

Marked this as a draft since the wordmark image the cndwrdmrk class was referencing is still out there...

EricDunsworth avatar Jun 04 '20 21:06 EricDunsworth

So after looking at it, the custom font is not used. We can go forward and remove the custom font CSS and the corresponding asset. Regarding the custom icon that was used for the breadcrumb, it was replaced by an "greater than" symbol when we did the major review GCWeb v5.

duboisp avatar Oct 13 '20 18:10 duboisp