GCWeb
GCWeb copied to clipboard
Apply gc 2019 font style to web form - Fix #1634
No obvious reason to format text differently just because it's inside a <form> element.
Also we will need an interim solution to let author/developper to use old font-size for existing form
. The font change would impact some existing form design and the new font might require to redesign those form.
/cc @delisma
We are currently in contravention of the Canada.ca design system. This PR fixes that.
From https://design.canada.ca/styles/typography.html:
The typography guidance is mandatory on all pages.
There is no exception for forms.
@jkshapiro In these trying times, I don't think any hard consequences will fall on anybody. I think what @duboisp wants is to unearth the edge cases where the font size change breaks the layout and offer a way to stay on the former text size until these layouts are fixed.
I agree that there could potentially be risks in retroactively increasing the font size of pre-existing forms. But having said that... similar risks existed for increasing the baseline font size on everything else, yet that change was still pushed through. Although I presume that involved a lot of advance testing.
At this point, it's been more than a year since GCWeb's baseline font size was dramatically increased. Anyone that has tried creating new forms on Canada.ca over the past year has had to deal with their forms looking really small compared to "normal" content. No special class is currently available to change form fonts to match the baseline font "on demand".
If there's no appetite or capacity to do any advance research/coordination/etc that might be necessary before merging this PR, could a special class at least be introduced to allow developers to force net-new forms to use the baseline font?
Related: #1634